Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Don't move trivially copyable values. #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

cleanup: Don't move trivially copyable values.

bf7125e
Select commit
Loading
Failed to load commit list.
Open

cleanup: Don't move trivially copyable values. #79

cleanup: Don't move trivially copyable values.
bf7125e
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Nov 21, 2024 in 26s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Don't move trivially copyable values.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : cleanup: Don't move trivially copyable values.
run-clang-tidy -p _build -fix $(find . -name "*.h" -or -name "*.cpp" \
    -or -name "*.c" | grep -v "/_build/") \
    -checks="-*,performance-move-const-arg"

Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : ```sh
    run-clang-tidy -p _build -fix $(find . -name ".h" -or -name ".cpp"
    -or -name ".c" | grep -v "/_build/")
    -checks="-
    ,performance-move-const-arg"

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/TokTok/qTox/79)
<!-- Reviewable:end -->

 Settings : ```{"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}```
<!-- #mergeable-data {"id":33340936912,"eventName":"pull_request","action":"milestoned"} #mergeable-data -->