refactor: Make code less dependent on the Settings object. #110
3 checks passed!
Status: PASS
Details
✔️ Validator: TITLE
- ✔️ All the requisite validations passed for 'or' option
Input : refactor: Make code less dependent on the Settings object.
Settings :{"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}
✔️ Validator: COMMIT
- ✔️ Your commit messages met the specified criteria
Input : refactor: Make code less dependent on the Settings object.
Instead, use smaller subsets of that object instead.
All of this was necessary to create our first golden-capture test. We
check that the login screen renders correctly and according to an
image reference.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}
✔️ Validator: DESCRIPTION
- ✔️ description must exclude '\[ \]'
Input : Instead, use smaller subsets of that object instead.
All of this was necessary to create our first golden-capture test. We check that the login screen renders correctly and according to an image reference.
We're only running the test on the bazel-opt build, because there we have tight control over which Qt version we run. We're doing a byte-for-byte comparison, so the screenshot has to be pixel-perfect.
Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}