refactor: Make code less dependent on the Settings object. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
iphydf
force-pushed
the
loginscreen-test
branch
4 times, most recently
from
c7a72a2
to
2982bea
Compare
iphydf
force-pushed
the
loginscreen-test
branch
from
2982bea
to
c1c9544
Compare
iphydf
force-pushed
the
loginscreen-test
branch
4 times, most recently
from
b440951
to
1bfb4b2
Compare
iphydf
force-pushed
the
loginscreen-test
branch
11 times, most recently
from
3f16233
to
86a341b
Compare
robinlinden
approved these changes
Nov 22, 2024
Instead, use smaller subsets of that object instead. All of this was necessary to create our first golden-capture test. We check that the login screen renders correctly and according to an image reference.
iphydf
force-pushed
the
loginscreen-test
branch
from
86a341b
to
a79fe0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, use smaller subsets of that object instead.
All of this was necessary to create our first golden-capture test. We check that the login screen renders correctly and according to an image reference.
We're only running the test on the bazel-opt build, because there we have tight control over which Qt version we run. We're doing a byte-for-byte comparison, so the screenshot has to be pixel-perfect.
This change is