Skip to content

Commit

Permalink
revert breaking changes to geom_bar
Browse files Browse the repository at this point in the history
  • Loading branch information
@rdboyes
rdboyes committed Apr 9, 2024
1 parent 045302d commit ecf5d73
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions src/geoms/geom_bar.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,6 @@ function handle_position(aes_dict::Dict{String, Symbol},
@ungroup
end
end
else # this is for geom_col
if haskey(args_dict, "direction")

else if plot_data[!, aes_dict["x"]] <: Union{AbstractString, AbstractChar}
grouping_var = Symbol(aes_dict["x"])
aes_dict["y"] = :count
required_aes = ["x", "y"]
elseif haskey(aes_dict, "y") && !haskey(aes_dict, "x")
grouping_var = Symbol(aes_dict["y"])
aes_dict["x"] = :count
args_dict["direction"] = "x"
required_aes = ["y", "x"]
end

return (aes_dict, args_dict, required_aes, plot_data)
Expand Down

2 comments on commit ecf5d73

@rdboyes
Copy link
Member Author

@rdboyes rdboyes commented on ecf5d73 Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/104566

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.6.5 -m "<description of version>" ecf5d732e76ddc18230209f9b460d2c004a7f537
git push origin v0.6.5

Please sign in to comment.