Skip to content

Commit

Permalink
adds julia 1.9 to test versions
Browse files Browse the repository at this point in the history
  • Loading branch information
rdboyes committed Apr 9, 2024
1 parent 33740fb commit 045302d
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.9'
- '1.10'
- 'nightly'
os:
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Loess = "0.6"
Makie = "0.20.8"
Reexport = "1.2"
TidierData = "0.15"
julia = "1.10"
julia = "1.9"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
12 changes: 12 additions & 0 deletions src/geoms/geom_bar.jl
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ function handle_position(aes_dict::Dict{String, Symbol},
@ungroup
end
end
else # this is for geom_col
if haskey(args_dict, "direction")

else if plot_data[!, aes_dict["x"]] <: Union{AbstractString, AbstractChar}
grouping_var = Symbol(aes_dict["x"])
aes_dict["y"] = :count
required_aes = ["x", "y"]
elseif haskey(aes_dict, "y") && !haskey(aes_dict, "x")
grouping_var = Symbol(aes_dict["y"])
aes_dict["x"] = :count
args_dict["direction"] = "x"
required_aes = ["y", "x"]
end

return (aes_dict, args_dict, required_aes, plot_data)
Expand Down

0 comments on commit 045302d

Please sign in to comment.