-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to CXX standard 17 and add CMakeLists file to directories without them #2746
Merged
realstealthninja
merged 50 commits into
TheAlgorithms:master
from
realstealthninja:cmake
Nov 4, 2024
Merged
feat: update to CXX standard 17 and add CMakeLists file to directories without them #2746
realstealthninja
merged 50 commits into
TheAlgorithms:master
from
realstealthninja:cmake
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd `operations_on_datastructures` subdirectories to cmakelists.txt
Arm supports c++ 17 Esp32 supports c++ 23 decision was made to be 17 because it seemed to offer the best combatability
#2717 is a prerequisite to this pr. |
realstealthninja
changed the title
chore: Update CXX standard to 17 and add
feat: Update CXX standard and add CMakeLists file to directories without them
Oct 4, 2024
CMakeLists.txt
to directories without them
realstealthninja
changed the title
feat: Update CXX standard and add CMakeLists file to directories without them
feat: Update to CXX standard 17 and add CMakeLists file to directories without them
Oct 4, 2024
realstealthninja
added
dont-close
This issue/pull request shouldn't be closed
awaiting review
pull request is waiting to be reviewed
labels
Oct 4, 2024
realstealthninja
changed the title
feat: Update to CXX standard 17 and add CMakeLists file to directories without them
feat: update to CXX standard 17 and add CMakeLists file to directories without them
Oct 4, 2024
realstealthninja
commented
Oct 5, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting review
pull request is waiting to be reviewed
dont-close
This issue/pull request shouldn't be closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
CMakeLists.txt changes
Some directories lack CMakeLists Thus giving any algorithms under those directories
cmake specific changes
So this pr focuses on the the inclusion of the CMakeLists file and fixing compilation problems
associated with the inclusion of the directories
File renames
some files had to be renamed due to file name conflicts with pre-existing files. I would love feedback on the names. These algorithms are duplicates with alot of history associated with them removing them seemed like not my decision to make.
Code changes
Some older code was updated very slightly just enough to make them compile as the scope of this pr is not part of #2456
The updated code include;
Standard updated
This is the part of the pr where I explain my thought process behind this update in such a minor pr.
here are some of my arguments:
Checklist
Notes: