-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ripemd160.cpp #2796
Conversation
updated all changes that was posted in this PR |
updated recently requested changes |
Kindly ping me for any other clarifications |
I have some warnings in functions with switch cases that the control may reach the end of a fucntion without returning anything. But all of them are internal functions and it can be proved that the control can never reach the end of the function without returning anything. How can we handle this? can this be ignored or should I handle to not produce any warnings? Example of the warning is provided below. C-Plus-Plus\hashing\ripemd_160.cpp:66:5: warning: control reaches end of non-void function [-Wreturn-type] |
If j > 5 your function wont return anything. Throw and error in a default case. Probably an invalid argument error also add a @note to the functions with the switch statement stating that j must be less than 5 |
… into ripemd_160
resolved warnings |
Kindly ping me for any other clarifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this pr!
@Panquesito7 can you review the code if its good to go? |
…me to evade errors when built on mac environment
/Users/runner/work/C-Plus-Plus/C-Plus-Plus/hashing/ripemd_160.cpp:354:50: error: must explicitly qualify name of member function when taking its address Got this error when running on mac environment. I modified the code as std::thread compute_for_block_thread(&RIPEMD160::compute_for_block, this, &A, If there is still any issue, kindly ping me. |
Description of Change
Implemented the RIPEMD160 hashing, per request #2795
Checklist
Notes: Implemented the RIPEMD160 hashing algorithm. Implemented using threads for parallel processing.