Remove restricted user type/attribute
#354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reefdog
force-pushed
the
353-remove-restricted-user
branch
from
e9584f7 to
f43c4b5
Compare
cguess
approved these changes
Sep 20, 2022
Before removing the attribute entirely, let’s first stop treating the interface any differently based on restricted status. The commit removes any special/limited version of the interface for restricted users. There are also a few places we were doing a `current_user.nil?` check that was no longer necessary since `before_action :authenticate_user!` was already handling that. Issue #353
This commit removes the `restricted` attribute from the `User` model and removes the (unused) seed for this user type. Issue #353
reefdog
force-pushed
the
353-remove-restricted-user
branch
from
f43c4b5 to
25efdff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the concept of "restricted" users. Under the current permissions model, we don't have this concept anymore, so this removes the attribute and the interface-splitting that fed a stripped-down experience to this user type.
Testing:
rails tof courserails sand log in with[email protected]and poke around major functionality, particularly searching and archiving. Nothing should have changed from before.[email protected]if you feel so inclined.Closes #353