Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove user.restricted attribute #353

Closed
reefdog opened this issue Sep 20, 2022 · 0 comments · Fixed by #354
Closed

Remove user.restricted attribute #353

reefdog opened this issue Sep 20, 2022 · 0 comments · Fixed by #354
Assignees
@reefdog
Milestone
Sprint 4

Comments

@reefdog
Copy link
Contributor

reefdog commented Sep 20, 2022

We no longer have need for the idea of a "restricted" user, and any additional finessing that needs doing will be through roles (#349).

Let's remove the attribute and all the interface-splitting.
@reefdog reefdog self-assigned this Sep 20, 2022
@reefdog reefdog added this to the Sprint 4 milestone Sep 20, 2022
reefdog added a commit that referenced this issue Sep 20, 2022
@reefdog
Remove interface-splitting for restricted users
d7b3dc9 
Before removing the attribute entirely, let’s first stop treating the
interface any differently based on restricted status.

The commit removes any special/limited version of the interface for
restricted users.

There are also a few places we were doing a `current_user.nil?` check
that was no longer necessary since `before_action :authenticate_user!`
was already handling that.

Issue #353
reefdog added a commit that referenced this issue Sep 20, 2022
@reefdog
Remove the restricted attribute from users
e9584f7 
This commit removes the `restricted` attribute from the `User` model and
removes the (unused) seed for this user type.

Issue #353
@reefdog reefdog mentioned this issue Sep 20, 2022
Merged
@reefdog reefdog linked a pull request Sep 20, 2022 that will close this issue
Remove restricted user type/attribute #354
Merged
reefdog added a commit that referenced this issue Sep 20, 2022
@reefdog
Remove interface-splitting for restricted users
2b76362 
Before removing the attribute entirely, let’s first stop treating the
interface any differently based on restricted status.

The commit removes any special/limited version of the interface for
restricted users.

There are also a few places we were doing a `current_user.nil?` check
that was no longer necessary since `before_action :authenticate_user!`
was already handling that.

Issue #353
reefdog added a commit that referenced this issue Sep 20, 2022
@reefdog
Remove the restricted attribute from users
f43c4b5 
This commit removes the `restricted` attribute from the `User` model and
removes the (unused) seed for this user type.

Issue #353
reefdog added a commit that referenced this issue Sep 20, 2022
@reefdog
Remove interface-splitting for restricted users
5ccc7ad 
Before removing the attribute entirely, let’s first stop treating the
interface any differently based on restricted status.

The commit removes any special/limited version of the interface for
restricted users.

There are also a few places we were doing a `current_user.nil?` check
that was no longer necessary since `before_action :authenticate_user!`
was already handling that.

Issue #353
reefdog added a commit that referenced this issue Sep 20, 2022
@reefdog
Remove the restricted attribute from users
25efdff 
This commit removes the `restricted` attribute from the `User` model and
removes the (unused) seed for this user type.

Issue #353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reefdog reefdog

Labels
None yet
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging a pull request may close this issue.

Remove restricted user type/attribute TechAndCheck/zenodotus
1 participant
@reefdog