Part of #1117: Update electron to v34

[tupaschoal]

Collaborative draft to work on the tests failures. With this upgrade, 3 tests fail with the following log:

1:

  1) main-window.mjs
       createWindow()
         Should create and get window default behaviour:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

2 !== 1

      + expected - actual

      -2
      +1

      at Context.<anonymous> (file:///C:/GitHub/time-to-leave/__tests__/__main__/main-window.mjs:84:20)
      at process.processImmediate (node:internal/timers:483:21)

2:

  2) Windows tests
       Should reset waiverWindow on close:
     Uncaught TypeError: Cannot read properties of undefined (reading 'defaultPrevented')
      at node:electron/js2c/browser_init:2:13112
      at node:internal/process/task_queues:140:7
      at AsyncResource.runInAsyncScope (node:async_hooks:206:9)
      at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
      at s.send (node:electron/js2c/browser_init:2:92689)
      at _.send (node:electron/js2c/browser_init:2:76113)
      at BrowserWindow.<anonymous> (file:///C:/GitHub/time-to-leave/js/windows.mjs:50:32)
      at BrowserWindow.emit (node:events:530:35)
      at Context.<anonymous> (file:///C:/GitHub/time-to-leave/__tests__/__main__/windows.mjs:86:27)
      at process.processImmediate (node:internal/timers:483:21)

3:

  3) Windows tests
       Should reset waiverWindow on close:
     Error: done() called multiple times in test <Windows tests Should reset waiverWindow on close> of file C:\GitHub\time-to-leave\__tests__\__main__\windows.mjs
      at process.processImmediate (node:internal/timers:483:21)

[tupaschoal]

a7a4acb fixes the issue 3, and reduces the size of 2 (??) Seems like we need to mock/stop the defaultPrevent from running. Here's how 2 looks after it:

  1) Windows tests
       Should reset waiverWindow on close:
     Uncaught TypeError: Cannot read properties of undefined (reading 'defaultPrevented')
      at node:electron/js2c/browser_init:2:13112
      at node:internal/process/task_queues:140:7
      at AsyncResource.runInAsyncScope (node:async_hooks:206:9)
      at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

[tupaschoal]

4636014 fixes the issue #1. Apparently there is one more listener to the 'close' event for the main window.
Printing it gets us:

[ [Function (anonymous)], [Function (anonymous)] ]

It doesn't seem to be ours though, as I commented them all out and would still get a 1. My wild guess is that it comes from this patch electron/electron#44629 , but it doesn't seem to matter much, since the only thing failing is the listener count.