Part of #1117: Update electron to v34 (#1123)

* Part of #1117: Update electron from 32.2.8 to 33.3.1

Need to bump to node 20.18

* Part of #1117: Update electron from 33.3.1 to 34.0.0

* Update listener count for 'close' event on main window

* Calling BrowserWindow.close() rather than emit('close') on failing test

* Part of #1117: Update electron from 34.0.0 to 34.0.1

DEVELOPMENT.md

@@ -27,7 +27,7 @@ Working on your first Pull Request? You can learn how from this _free_ series [H
 
 ## Environment
 
-- Install [Node.js](https://nodejs.org/en/): version 20.12 or higher
+- Install [Node.js](https://nodejs.org/en/): version 20.18 or higher
 - Install [git](https://git-scm.com/)
 
 ## Setup

__tests__/__main__/main-window.mjs

@@ -79,7 +79,7 @@ describe('main-window.mjs', () =>
             assert.strictEqual(ipcMain.listenerCount('SWITCH_VIEW'), 1);
             assert.strictEqual(ipcMain.listenerCount('RECEIVE_LEAVE_BY'), 1);
             assert.strictEqual(mainWindow.listenerCount('minimize'), 2);
-            assert.strictEqual(mainWindow.listenerCount('close'), 1);
+            assert.strictEqual(mainWindow.listenerCount('close'), 2);
             assert.strictEqual(loadFileSpy.calledOnce, true);
             assert.strictEqual(showSpy.calledOnce, true);
             assert.notStrictEqual(getLeaveByInterval(), null);

__tests__/__main__/windows.mjs

@@ -78,7 +78,7 @@ describe('Windows tests', () =>
             show: false
         });
         Windows.openWaiverManagerWindow(mainWindow, true);
-        Windows.getWaiverWindow().emit('close');
+        Windows.getWaiverWindow().close();
         assert.strictEqual(Windows.getWaiverWindow(), null);
     });