display tempo popups on first encoder detent, change value on later ones #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikodemus
changed the title
|
...and forgot to format 😝 |
m-m-adams
approved these changes
Jul 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
This picked up some conflicts |
Seems I completely forgot about the overlap with the swing interval branch. 💩 |
nikodemus
force-pushed
the
pr-popup-first-then-change
branch
from
2b51d86 to
e609e22
Compare
nikodemus
changed the title
nikodemus
force-pushed
the
pr-popup-first-then-change
branch
from
e609e22 to
e0025c5
Compare
Merged
via the queue into
SynthstromAudible:community
with commit Jul 18, 2024
3508d9d
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to tempoEncoderAction() are probably easiest read one commit at a time.