display quantize/humanize mode for first encoder detent, then quantize #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nikodemus
commented
Jul 12, 2024
•
nikodemus
commented
- explicit UI_QUANTIZE_MODE, which silences auditions as soon as the tempo encoder is pressed while holding an audition pad
- the mode stays on as long as any audition pads remain pressed
- on first encoder detent the popup says either "humanize" or "quantize" depending on the encoder direction (plus "all" when necessary)
- fix prevention of tempo-encoder popup on audition + tempo press, instead display HUMANIZE/QUANTIZE ALL" as a hint. I believe this is a lefover from the original patch, which I believe used pad pressed instead of audition to quantize?
- For 7seg, when displaying the humanize/quantize all amount, prefix it with A as long as the result fits on the screen nicely.
nikodemus
force-pushed
the
pr-humanize-popup-first
branch
4 times, most recently
from
e982b1d to
294eaa2
Compare
- on first encoder detent the popup says either "humanize" or "quantize" depending on the encoder direction (plus "all" when necessary) - For 7seg, when displaying the humanize/quantize all amount, prefix it with A as long as the result fits on the screen nicely. - explicit UI_QUANTIZE_MODE, which silences auditions as soon as the tempo encoder is pressed while holding an audition pad - the mode stays on as long as any audition pads remain pressed - fix prevention of tempo-encoder popup on audition + tempo press, instead display "HUMANIZE/QUANTIZE ALL" as a hint. I believe this is a lefover from the original patch, which I believe used pad pressed instead of audition to quantize?
nikodemus
force-pushed
the
pr-humanize-popup-first
branch
from
294eaa2 to
a96416b
Compare
m-m-adams
approved these changes
Jul 19, 2024
Merged
via the queue into
SynthstromAudible:community
with commit Jul 20, 2024
4f36e03
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.