Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
409 whats new page #426
409 whats new page #426
Changes from 23 commits
0192dc6
0af004d
015d4f9
ab613ba
78cf9c3
bc7d038
008b8bd
1f5729f
d05ed2b
9c8d36a
7e128d5
803c6ba
54c7a23
5c7e609
bec1cc7
96e6894
475608e
126be17
1901130
13372e3
ccc3be6
9b050f1
f362ea9
1cb2c23
088fbef
228ebc0
8fa4780
9bdc4b2
51ccaec
82c6931
9e2087f
2df7879
62d93b2
7bad76f
ba6235d
20ea664
a93b599
36b24a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Do we even need sort, direction & isMerged as parameters here? If I didnt miss something, these values are hard coded in the frontend and there is no button to change them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for adding those params is extensibility in the future, if needed. For example lets say in the future there is new feature request - add options which give the user ability to sort the prs in the 'What's new page' by different params. This way only the frontend will need changes