Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

409 whats new page #426

Merged
merged 38 commits into from
Nov 30, 2023
Merged

409 whats new page #426

merged 38 commits into from
Nov 30, 2023

Conversation

Valeri12580
Copy link
Contributor

@Valeri12580 Valeri12580 commented Oct 4, 2023 •
edited
Loading

PR regarding the 'What's New page milestone'.

One important thing
The code is making api calls to github rest api in order to get the pull requests. Unfortunately the request limit for unauthenticated users is 60 requests per hour. One possible fix is adding access token to the api requests which will increase the limit to 5000 requests per hour. I added property in application properties vsc.github.access-token = ${GITHUB_ACCESS_TOKEN:null} which will see if there are env variable containing the token and if yes - will use it.

You can find more here: https://docs.github.com/en/apps/creating-github-apps/registering-a-github-app/rate-limits-for-github-apps

@SponsoredByPuma
Copy link
Contributor

Hey @Valeri12580,
it looks really great! Well done.

I've got few points which i would like to mention.

  1. Sorting of the PR's

    • I feel like it would be useful to sort the pull requests by recently updated instead of newest.
    • that way to latest updated PR is the first one, instead of the newest created Pull Request.
    • maybe you could find another way to sort the Pull Requests, by their merge date <-- this would be the best option

image
(sorted by newest Pull Request)

image

  1. Date of the User Stories

    • currently the date is the ISO 8601 format, which makes it quite hard to read. Maybe you could adjust the date to something like this for example: "01. March 2023". I'm not sure if it is possible to translate the name of the month in other languages, but it would be awesome. (translation could be optional, if it is too hard)

  2. Group Pull Requests by Month

    • This is one would be very optional, but maybe we could group the pull requests by their month. (This would only work if it is possible to sort the PR after their merge date)
    • here is a small mock up for you, on how it could look like:
      image

  3. Page Size

    • I feel like currently the page is too long. Maybe you could add at the bottom of the page a navigator to get to the next page of Pull Requests. Here is an example of what I mean:
      image

    • If the grouping of the pull requests works, we could add a new page to every new year. Here is a small (and ugly 😆 ) mock up:
      image

Thank you for contributing to our project. You did a great job already.
If you got any questions feel free to contact me on discord 😄

@Valeri12580
Copy link
Contributor Author

Hi @SponsoredByPuma,
thank you for your feedback. I make some improvements later :)

Valeri added 5 commits October 9, 2023 12:45
Merge branch 'main' into 409-whats-new-page
bec1cc7
Change sorting by updated at
96e6894
Add date new date format and localization for the date
475608e
Add two types of sorting:
126be17 
1.is_merged = false - sort the prs by the #number.
2.is_merged = true - sort the prs by the merged_date
Add two types of sorting:
1901130 
1.is_merged = false - sort the prs by the #number.
2.is_merged = true - sort the prs by the merged_date
@SponsoredByPuma SponsoredByPuma added userstory New feature or request java Pull requests that update Java code javascript Pull requests that update Javascript code frontend backend feature request labels Oct 10, 2023
@SponsoredByPuma SponsoredByPuma self-requested a review October 11, 2023 09:28
1.Add 'What's new page link to the FooterBar.vue. Removed from the he…
1cb2c23 
…ader.

2.Remove redundant variables.
3.Remove merget_at filter
@SponsoredByPuma
Copy link
Contributor

Hello @Valeri12580,
I'm not sure if you saw it already, but the Pull Request is failing in the workflow.
image
Could you update the PR?

@Valeri12580
Copy link
Contributor Author

Hello @Valeri12580, I'm not sure if you saw it already, but the Pull Request is failing in the workflow. image Could you update the PR?

Hi @SponsoredByPuma, sorry for the delay, I will try to update it today

Valeri and others added 10 commits October 18, 2023 14:04
Merge branch 'main' into 409-whats-new-page
088fbef 
# Conflicts:
#	frontend/src/locales/es.json
#	frontend/src/services/api.service.ts
Fix
228ebc0
@stritti
fix: remove autofix of linter on forked PRs
8fa4780
@stritti
fix: precent comit on backend action
9bdc4b2
Merge branch 'main' into 409-whats-new-page
51ccaec 
# Conflicts:
#	frontend/src/components/navigation/TopNavigationBar.vue
Add support for dark mode
82c6931
Merge remote-tracking branch 'upstream/fix/456-build-fail-at-forked-p…
9e2087f 
…rojects' into 409-whats-new-page
Merge branch 'main' into 409-whats-new-page
2df7879
Merge branch 'main' into 409-whats-new-page
62d93b2 
# Conflicts:
#	frontend/src/components/navigation/TopNavigationBar.vue
Fix
7bad76f
@SponsoredByPuma SponsoredByPuma merged commit b0f62d8 into Sybit-Education:main Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan1elBox Dan1elBox Dan1elBox approved these changes

@SponsoredByPuma SponsoredByPuma SponsoredByPuma approved these changes

@stritti stritti Awaiting requested review from stritti

Assignees
No one assigned
Labels
backend feature request frontend hacktoberfest HACKTOBERFEST-ACCEPTED java Pull requests that update Java code javascript Pull requests that update Javascript code userstory New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@Valeri12580 @SponsoredByPuma @Dan1elBox @stritti