-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for cloning public projects #10
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
87f0596
Allow version for client only, in case server doesn't respond
eikek 690c23d
Get details of a project by namespace/slug or id
eikek 00e5816
Add rudimentary git cloning
eikek 3b6f6b2
Clone sequentially
eikek d84d2ff
baby steps
eikek d131249
Cloning async and parallel if possible
eikek 35cd0a2
Write renku config when cloning
eikek 8f6de0d
Write test file to /tmp
eikek 31ae2eb
Fix userdoc cmd that broke due to refactor
eikek d0b0e7d
Allow a complete (ui) url for cloning
eikek b0d8d66
Run installer check on main only
eikek c5d1729
Add version field to config file
eikek ca6370e
Create api url consistently
eikek 959ca4a
Rename config -> project_config
eikek 632256d
Add code owners file
eikek fc65139
Parse user supplied urls into reqwest::Url
eikek 1633930
Implement review feedback, part1
eikek 121e851
Remove `as_string` and move impl into Display
eikek ec55a62
Fix doc strings
eikek 8f90583
Remove last occurence of as_string
eikek cc024bf
Introduce RenkuUrl type and reorganize a bit
eikek 66f6a2e
Error early when name cannot be derived from repo url
eikek 8171a93
Rename write -> write_out
eikek 9fc7d8d
Lost a change
eikek c347809
Make a alias 'clone' for 'project clone'
eikek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* @SwissDataScienceCenter/renku-python-maintainers @SwissDataScienceCenter/renku-graph-maintainers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I wonder if we should have a
write_info
andwrite_err
, both going to stderr but formatting output slightly differently? Like it could beINFO: message
andERROR: message
. My main motivation is that havingwrite_err
in the codebase when writing progress could be a bit confusing, as someone new might think it's writing an actual error, not writing to stderr.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The little difficulty here is that we always need to consider json and human-readable output. So while we can change the output for human-readable, it doesn't look so great for the json variant, or?
The general guideline for the cli part of the codebase (currently) is to only write the actual result to stdout and logging/progress always to stderr.
I also find
write
andwrite_err
not great… I could also renamewrite
towrite_out
or similar? so at least they show their relationship better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renaming it to show the relationship better makes sense.
But just to make sure I understand, actual errors we write to stdout as json if the format is json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that at least is the intention or suggestion right now. If the outcome of the command is an error it should go as json to stdout. stderr would be for non-result output, like progress or debug logging (if verbose flag is set). When doing logging, there is just plain text, no json right now.