Basic support for cloning public projects #10
Conversation
eikek
force-pushed
the
project-clone
branch
2 times, most recently
from
2760ad2 to
fddf35b
Compare
eikek
changed the title
To make it different to a overall cli config
There was a problem hiding this comment.
I think most (all?) of the as_string methods should be impl Into<String> for Type instead, that way they integrate better with the rust ecosystem in general.
Some of the suggestions I think should work but I'm far from a Rust expert and not sure if it actually compiles :/
| @@ -35,6 +35,12 @@ impl Context<'_> { | |||
| let fmt = self.opts.format; | |||
| Sink::write(&fmt, value) | |||
| } | |||
|
|
|||
| /// A short hand for `Sink::write_err(self.format(), value)` | |||
| async fn write_err<A: Sink + Serialize>(&self, value: &A) -> Result<(), SinkError> { | |||
There was a problem hiding this comment.
thought: I wonder if we should have a write_info and write_err, both going to stderr but formatting output slightly differently? Like it could be INFO: message and ERROR: message. My main motivation is that having write_err in the codebase when writing progress could be a bit confusing, as someone new might think it's writing an actual error, not writing to stderr.
There was a problem hiding this comment.
The little difficulty here is that we always need to consider json and human-readable output. So while we can change the output for human-readable, it doesn't look so great for the json variant, or?
The general guideline for the cli part of the codebase (currently) is to only write the actual result to stdout and logging/progress always to stderr.
I also find write and write_err not great… I could also rename write to write_out or similar? so at least they show their relationship better?
There was a problem hiding this comment.
renaming it to show the relationship better makes sense.
But just to make sure I understand, actual errors we write to stdout as json if the format is json?
There was a problem hiding this comment.
yes, that at least is the intention or suggestion right now. If the outcome of the command is an error it should go as json to stdout. stderr would be for non-result output, like progress or debug logging (if verbose flag is set). When doing logging, there is just plain text, no json right now.
`reqwest::Url` parses absolute http(s) urls, whereas `url::Url` parses much more url varients. But `reqwest::Url` reuses the `url::ParseError` afaict.
Whith Display, the `to_string` is auto-generated
- put our data types into `data`, each in its own module (remove util::data) - RenkuUrl is a newtype necessary to provide serde impls
Allows to clone a renku project by cloning all its git repositories (it assumes git).
Running:
gets the project from data-services, and git-clones all its repositories to the local file system. It also writes a file in
.renku/config.tomlcontaining the information about the origin of the project.The
<project-ref>can be the projectid, itsnamespace/slugidentifier or a complete url (copied from the browser).