Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling whitespace before first comment #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix handling whitespace before first comment #50

wants to merge 2 commits into from

Conversation

Nokel81
Copy link

@Nokel81 Nokel81 commented May 9, 2022

Signed-off-by: Sebastian Malton [email protected]

fixes #47

@Nokel81 Nokel81 mentioned this pull request May 9, 2022
Open
Stuk
Stuk requested changes May 23, 2022
View reviewed changes
Copy link
Owner

@Stuk Stuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the tests! Would you mind addressing my comment, and adding a couple of code comments to explain what the checks are doing?

Thank you!

lib/rules/header.js Show resolved Hide resolved
@Nokel81
Add comments and a few more tests
fe321e0 
Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81
Copy link
Author

Nokel81 commented May 24, 2022

@Stuk Done, hope the comments help with understanding what I have added.

@Stuk
Copy link
Owner

Stuk commented May 26, 2022

Thanks! I'll take a look

@Nokel81
Copy link
Author

Nokel81 commented Jan 18, 2023

@Stuk ping. Could you take another look please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stuk Stuk Stuk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty first line breaks the header plugin
2 participants
@Nokel81 @Stuk