Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty first line breaks the header plugin #47

Open
donmahallem opened this issue Jan 2, 2022 · 3 comments · May be fixed by #50
Open

Empty first line breaks the header plugin #47

donmahallem opened this issue Jan 2, 2022 · 3 comments · May be fixed by #50

Comments

@donmahallem
Copy link

Currently if the first line is emtpy in the source file and the header starts at line 2 the fixer causes the header to be output many(non consistent but 10+ times) times in succession.
@Nokel81 Nokel81 linked a pull request May 9, 2022 that will close this issue
Open
@Nokel81
Copy link

Nokel81 commented May 9, 2022

I have made #50 to resolve this issue.

@TannerGilbert TannerGilbert mentioned this issue Jan 26, 2024
Merged
@lizozom
Copy link

lizozom commented Mar 17, 2024 •
edited
Loading

For anyone interested in this, adding the @stylistic/js/no-multiple-empty-lines rule with maxBOF: 0 before this one fixes the issue.

@lizozom lizozom mentioned this issue Mar 17, 2024
Merged
@lizozom
Copy link

lizozom commented Mar 17, 2024

Community PR:
Outburn-IL/fume-community#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling whitespace before first comment Nokel81/eslint-plugin-header
3 participants
@lizozom @donmahallem @Nokel81