Fix mac install #113
Open
Fix mac install #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineMoPa
commented
Apr 27, 2023
| @@ -265,8 +265,8 @@ export interface VideoInputParam extends InputParam { | |||
| height: number | |||
| pixelFormat: string | |||
| pixelAspect: Array<number> | |||
| hw_device_ctx: HWDeviceContext // Optional | |||
There was a problem hiding this comment.
That could be a separate PR, but I noticed the types were causing issues in my package. Looks like they are optional, so these ? should not hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mac install is currently broken because brew installs ffmpeg 6 - and if we try to install ffmpeg 5, it goes to a different location now.
Based on the linux install, it looks like beamcoder expects ffmpeg 5, so here I'm asking brew for
ffmpeg@5. Maybe we can switch everything to ffmpeg 6? In the meantime, at least this fixes the mac build.m1
Also, the build is failing on m1, since homebrew installs arm sofware in
/opt/homebrew/Cellar/instead of/usr/local/Cellar/.