-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): add ci for beamcoder #2
Conversation
@animanathome , do you remember, publishing of this package is just yarn publish, o did you build something locally? |
I think I just published manually, I thought it would just be a temporary repo until Streampunk#113 would be merged. Sadly, I lost hope that the original repo would be maintained at this point. |
@stepancar do you think we should take more ownership of supporting beamcoder and updating it to newer ffmpeg version? Or you see this repo as temporary before we move on to something like webcodecs? |
name: Node.js Package | ||
|
||
on: | ||
release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stepancar can we have it publish when we merge to main branch? I feel like it's a lot of bureaucracy to have to create a release after merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antoineMoPa , let's skip it for now? I tried to make it similar to what we have for framefusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, makes sense to keep similar and eventually move everything at once to a new workflow.
I see this repo temporary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
add CI for beamcoder, similar to framefusion.