Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tailscale-control to 0.0.7, add exit node, nix support, device state check #504

Merged
merged 4 commits into from
Dec 31, 2023

Conversation

saumya-banthia
Copy link
Contributor

@saumya-banthia saumya-banthia commented Dec 21, 2023

Tailscale Control

Feature Addons:

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@saumya-banthia saumya-banthia requested a review from a team as a code owner December 21, 2023 05:34
@saumya-banthia saumya-banthia changed the title Bump 0.0.5, add exit node, nix support, device state check Bump tailscale-control to 0.0.5, add exit node, nix support, device state check Dec 21, 2023
@TrainDoctor TrainDoctor requested a review from a team December 24, 2023 17:57
@TrainDoctor
Copy link
Member

Good to go to testing.

@saumya-banthia
Copy link
Contributor Author

Not to be merged yet, exit node toggle needs fix. Will ping here once that is pushed.

@saumya-banthia
Copy link
Contributor Author

saumya-banthia commented Dec 26, 2023

Fix has been pushed. @philhzss give it a go once the fixed version is pushed to testing store and report back here.

@saumya-banthia saumya-banthia changed the title Bump tailscale-control to 0.0.5, add exit node, nix support, device state check Bump tailscale-control to 0.0.6, add exit node, nix support, device state check Dec 26, 2023
@saumya-banthia saumya-banthia changed the title Bump tailscale-control to 0.0.6, add exit node, nix support, device state check Bump tailscale-control to 0.0.7, add exit node, nix support, device state check Dec 27, 2023
@philhzss
Copy link

Tested and works 100% for me, exit node menu shows my exit node, can be toggled on and off as it should, and it all works.

@saumya-banthia
Copy link
Contributor Author

saumya-banthia commented Dec 28, 2023

Tested and works 100% for me, exit node menu shows my exit node, can be toggled on and off as it should, and it all works.

Thanks @philhzss, I just checked with Train, and he says to be able to count your review as official you would need to submit a test report, the format to which is linked here: https://wiki.deckbrew.xyz/en/user-guide/testing#submitting-a-test-report

This allows the plugin to be put into the main store.

@saumya-banthia
Copy link
Contributor Author

saumya-banthia commented Dec 30, 2023

Tested and works 100% for me, exit node menu shows my exit node, can be toggled on and off as it should, and it all works.

Thanks @philhzss, I just checked with Train, and he says to be able to count your review as official you would need to submit a test report, the format to which is linked here: https://wiki.deckbrew.xyz/en/user-guide/testing#submitting-a-test-report

This allows the plugin to be put into the main store.

@TrainDoctor do we have other testers who could look into this? I am assuming a developer reporting on their own plugin (myself) would not count.

@philhzss
Copy link

Tested and works 100% for me, exit node menu shows my exit node, can be toggled on and off as it should, and it all works.

Thanks @philhzss, I just checked with Train, and he says to be able to count your review as official you would need to submit a test report, the format to which is linked here: https://wiki.deckbrew.xyz/en/user-guide/testing#submitting-a-test-report

This allows the plugin to be put into the main store.

@TrainDoctor do we have other testers who could look into this? I am assuming a developer reporting on their own plugin (myself) would not count.

Hi,

Ah ok sorry about that. I should have the time later today, I will try to do it

@saumya-banthia
Copy link
Contributor Author

saumya-banthia commented Dec 30, 2023

Ah ok sorry about that. I should have the time later today, I will try to do it

No worries, I thought you might not see it for some time. Please do and tag Train in the same, so he can merge and close.

EDIT: Here's the report format for reference:

Decky version(s), SteamOS version(s)
A) Any major blocking issues that you encountered, if any.
B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
C) A list of currently installed plugins (Name and version preferred)
(This list is needed due to potential conflicts between plugins etc).
D) Yay/nay on to send to the production store or if it requires more testing.

and an important consideration:

Install the plugin from the testing store and begin using it, really try to break it!

@philhzss
Copy link

philhzss commented Dec 31, 2023

Here's the report format for reference:

Decky version(s), SteamOS version(s)
A) Any major blocking issues that you encountered, if any.
B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
C) A list of currently installed plugins (Name and version preferred)
(This list is needed due to potential conflicts between plugins etc).
D) Yay/nay on to send to the production store or if it requires more testing.

@TrainDoctor
@saumya-banthia

Alright I don't have that much to say because it's working well for me!
A) None
B) Perhaps the fact that you can't scroll down with the thumbsticks to see the list of current Tailscale devices / to see the QR code. I think this is because the lowest item you can "select" is the LAN toggle. To scroll further, the touch screen is required. Not really an issue but the only thing I could think of
C)

  • ProtonDB badges 1.0.11
  • Quick Launch 1.1.1
  • Audio Loader 1.5.1
  • MoonDeck 1.6.14
  • Power tools 1.4.0
  • Decky Recorder 0.3.5
  • SteamGridDB 1.3.3
  • Wine Cellar 0.1.4
  • PlayTime 1.0.0
  • Animation Changer 1.3.0
  • CSS Loader 2.0.2
  • Game Theme Music 1.4.0
  • Tab master 2.1.0
  • Battery Tracker 0.1.0
  • Deck Roulette 1.1.2
  • Deck Settings 1.3.0

D) I think it's good to go

@TrainDoctor TrainDoctor merged commit be15da5 into SteamDeckHomebrew:main Dec 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants