Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tailscale-control to 0.1.0, fix exit node typecasting flaw, cosmetic issue #508

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

saumya-banthia
Copy link
Contributor

@saumya-banthia saumya-banthia commented Jan 2, 2024

Tailscale Control

Perhaps the fact that you can't scroll down with the thumbsticks to see the list of current Tailscale devices / to see the QR code. I think this is because the lowest item you can "select" is the LAN toggle. To scroll further, the touch screen is required. Not really an issue but the only thing I could think of

NOTE: Known issue after the cosmetic fix, contents of the "Device Status" element seems to have padding on the left which has not been manually set (tried setting negative padding as well as using style property to try and align left/center, neither of which seem to work); if someone seeing this has a fix do suggest or a raise a PR with the fix here: https://github.com/saumya-banthia/tailscale-control/pulls.

EDIT: Fixed with a workaround here: saumya-banthia/tailscale-control@d1535fe

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@saumya-banthia
Copy link
Contributor Author

@DrunkenMurphy, once the build is deployed to testing, could you check and report back in this format:

Decky version(s), SteamOS version(s)
A) Any major blocking issues that you encountered, if any.
B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
C) A list of currently installed plugins (Name and version preferred)
(This list is needed due to potential conflicts between plugins etc).
D) Yay/nay on to send to the production store or if it requires more testing.

and an important consideration from the testing docs:

Install the plugin from the testing store and begin using it, really try to break it!

@saumya-banthia saumya-banthia changed the title Bump tailscale-control to 0.0.8, fix exit node typecasting flaw Bump tailscale-control to 0.0.9, fix exit node typecasting flaw, cosmetic issue Jan 2, 2024
@saumya-banthia saumya-banthia changed the title Bump tailscale-control to 0.0.9, fix exit node typecasting flaw, cosmetic issue Bump tailscale-control to 0.1.0, fix exit node typecasting flaw, cosmetic issue Jan 2, 2024
@TrainDoctor TrainDoctor requested a review from a team January 2, 2024 13:14
@TrainDoctor
Copy link
Member

Good to go to testing.

@saumya-banthia
Copy link
Contributor Author

@TrainDoctor, can we assign someone from the testing team?

@TrainDoctor
Copy link
Member

@SteamDeckHomebrew/decky-testers need a tester for this, thanks.

@DrunkenMurphy
Copy link

Decky version 2.10.10, SteamOS version 3.5.12, Steam version 1704329464

A) Any major blocking issues that you encountered, if any.
No issues

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
No issues

C) A list of currently installed plugins (Name and version preferred)
Animation Changer - 1.3.0-1
AutoFlatpaks - 1.6.5
Bluetooh - 2.1.0
Controller Tools - 1.1.2-1
Decky Recorder - 0.3.5
Decky Terminal - 0.3.0
Network Info - 1.0.0-1
Pause Games - 0.4.2-1
ProtonDB Badges - 1.0.11
SteamGridDB - 1.3.3
Tailscale Control - 0.1.0-5563bfs

D) Yay/nay on to send to the production store or if it requires more testing.
Yay - It worked perfectly, thanks!

@TrainDoctor
Copy link
Member

Will merge as soon as I'm confident the upload won't break. Thanks for testing!

@TrainDoctor TrainDoctor merged commit a23b0a5 into SteamDeckHomebrew:main Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants