Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to only pass complete account details to the account setup complete closure #79

Merged
merged 6 commits into from
Dec 9, 2024

Resolve swiftlint for 0.57.1

e8698a3
Select commit
Loading
Failed to load commit list.
Merged

Make sure to only pass complete account details to the account setup complete closure #79

Resolve swiftlint for 0.57.1
e8698a3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 9, 2024 in 0s

83.84% (+0.05%) compared to 7ffb73d

View this Pull Request on Codecov

83.84% (+0.05%) compared to 7ffb73d

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (7ffb73d) to head (e8698a3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   83.79%   83.84%   +0.05%     
==========================================
  Files         122      121       -1     
  Lines        5204     5251      +47     
==========================================
+ Hits         4360     4402      +42     
- Misses        844      849       +5     
Files with missing lines Coverage Δ
Sources/SpeziAccount/AccountConfiguration.swift 64.22% <ø> (ø)
Sources/SpeziAccount/AccountSetup.swift 91.52% <100.00%> (-0.55%) ⬇️
Sources/SpeziAccount/AccountStorageProvider.swift 100.00% <ø> (ø)
...ount/AccountValue/Collections/AccountDetails.swift 75.17% <100.00%> (+1.34%) ⬆️
...ccount/AccountValue/Keys/AccountDetailsFlags.swift 75.52% <ø> (+4.09%) ⬆️
...ces/SpeziAccount/Mock/InMemoryAccountService.swift 91.90% <ø> (+3.25%) ⬆️
...iAccount/Mock/InMemoryAccountStorageProvider.swift 100.00% <100.00%> (+28.21%) ⬆️
...ountSetup/SetupProvider/AccountServiceButton.swift 72.10% <ø> (ø)
...untSetup/SetupProvider/SignInWithAppleButton.swift 39.07% <ø> (ø)
...es/SpeziAccountMacros/SpeziAccountDiagnostic.swift 72.23% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4dcc7...e8698a3. Read the comment docs.