Make sure to only pass complete account details to the account setup complete closure #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 83.79% 83.84% +0.05%
==========================================
Files 122 121 -1
Lines 5204 5251 +47
==========================================
+ Hits 4360 4402 +42
- Misses 844 849 +5
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
1 task
Merged
1 task
PSchmiedmayer
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thank you for all the improvements here @Supereg; great to see this merged & incorporated in our apps 🚀
Supereg
added a commit
to StanfordSpezi/SpeziFirebase
that referenced
this pull request
Dec 9, 2024
…49) # Always notify Account when FirestoreAccountStorage receives snapshot ## ♻️ Current situation & Problem With StanfordSpezi/SpeziAccount#79 we only forward "complete" account details to the `setupComplete` closure of the `AccountSetup` view. This requires that the StorageProvider always updates the account details (to clear the incomplete flag) even if there aren't any keys stored in the storage provider. This wasn't the case for FirestoreAccountStorage resulting in the `setupComplete` closure to never be called and the `incomplete` flag to never be cleared. ## ⚙️ Release Notes * Fixed an issue where the `incomplete` flag would never be cleared if there weren't any details stored for an account. ## 📚 Documentation -- ## ✅ Testing -- ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to only pass complete account details to the account setup complete closure
♻️ Current situation & Problem
The
AccountSetupaccepts asetupCompleteclosure that will get called once the setup is completed giving the parent view the opportunity to perform additional checks or navigation steps based on the outcome. While aAccountServicealways calls anExternalStorageProviderbefore submitting account details toAccount, they have been decoupled in v2.0.0 and anExternalStorageProvidermust always return immediacy from itsloadcall. In scenarios where account details are not locally cached yet, anExternalStorageProviderreturns details that are marked as incomplete.AccountSetupdidn't check for this flag and forwarded incomplete details to thesetupCompleteclosure. This PR fixes this issue and updates the behavior to only forward account details that are also marked as complete.⚙️ Release Notes
AccountSetupwould forward incomplete account details and didn't wait for anExternalStorageProviderto load externally stored account details.flagswouldn't be copied between account details.📚 Documentation
We improved some of the documentation discoverability.
✅ Testing
Added UI tests to verify that the incomplete details are not passed to the
setupCompleteclosure.📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: