-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
careers page, various minor fixes #784 #786
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
df28d60
careers page, various minor fixes #784
zarSou9 2dd4cf1
Merge branch 'stampy-redesign' into supermandan
zarSou9 4e4f390
Styling fixes
zarSou9 9eff33e
linting
zarSou9 50efb4f
Merge branch 'stampy-redesign' into supermandan
zarSou9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import React from 'react' | ||
import './testimonial.css' | ||
import useIsMobile from '../../hooks/isMobile' | ||
|
||
interface TestimonialProps { | ||
className?: string | ||
title: string | ||
description: string | ||
src: string | ||
layout?: 'expanded' | 'squeezed' | ||
} | ||
|
||
const Testimonial: React.FC<TestimonialProps> = ({ | ||
className, | ||
title, | ||
description, | ||
src, | ||
layout = 'squeezed', | ||
}) => { | ||
const isMobile = useIsMobile() | ||
const finalLayout = isMobile ? 'squeezed' : layout | ||
className = `testimonial ${finalLayout} ${className || ''}` | ||
|
||
return finalLayout === 'squeezed' ? ( | ||
<div className={className}> | ||
<div className="padding-bottom-24 testimonial-header"> | ||
<img width={80} height={80} className="rounded" src={src} alt="Testimonial's Face" /> | ||
<p className="default-bold padding-left-24">{title}</p> | ||
</div> | ||
<p className="default grey">{description}</p> | ||
</div> | ||
) : ( | ||
<div className={className}> | ||
<div className="flex-container"> | ||
<img width={151} height={151} className="rounded" src={src} alt="Testimonial's Face" /> | ||
<div className="padding-left-40"> | ||
<p className="large-bold padding-bottom-16">{title}</p> | ||
<p className="default grey">{description}</p> | ||
</div> | ||
</div> | ||
</div> | ||
) | ||
} | ||
|
||
export default Testimonial |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
.testimonial { | ||
border: 1px solid var(--colors-cool-grey-200); | ||
border-radius: var(--border-radius); | ||
} | ||
|
||
.testimonial.expanded { | ||
padding: var(--spacing-40); | ||
max-width: 875px; | ||
margin-left: auto; | ||
margin-right: auto; | ||
} | ||
|
||
.testimonial.squeezed { | ||
padding: var(--spacing-32); | ||
} | ||
|
||
.testimonial-header { | ||
display: flex; | ||
align-items: center; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't this be done with css + a media query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was what I thought at first, but the layouts are just different. Like the puzzle doesn't fit. I can't articulate why, just look at the different versions and you can see what I mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's unfortunate, but happens. @melissasamworth it's all your fault!!