-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
careers page, various minor fixes #784 #786
Changes from all commits
df28d60
2dd4cf1
4e4f390
9eff33e
50efb4f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,16 +5,21 @@ type HelpItemProps = { | |
title?: ReactNode | ||
children: ReactNode | ||
links?: Link[] | ||
titleFont?: 'large-bold' | 'default-bold' | ||
} | ||
const HelpItem = ({title, children, links}: HelpItemProps) => { | ||
const HelpItem = ({title, children, links, titleFont = 'large-bold'}: HelpItemProps) => { | ||
return ( | ||
<div className="section-split padding-bottom-40"> | ||
<div> | ||
{title && <p className="default-bold padding-bottom-16">{title}</p>} | ||
{title && <p className={`padding-bottom-16 ${titleFont}`}>{title}</p>} | ||
<p className="grey default padding-bottom-16"> {children} </p> | ||
</div> | ||
<div> | ||
{links?.map((link) => <LinkCard key={link.title} action={link.action || '#'} {...link} />)} | ||
{links?.map((link) => ( | ||
<div key={link.title} className="padding-bottom-16"> | ||
<LinkCard action={link.action || '#'} {...link} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not apply the class directly to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because we are spacing with padding, and the padding would go inside the button |
||
</div> | ||
))} | ||
</div> | ||
</div> | ||
) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import React from 'react' | ||
import './testimonial.css' | ||
import useIsMobile from '../../hooks/isMobile' | ||
|
||
interface TestimonialProps { | ||
className?: string | ||
title: string | ||
description: string | ||
src: string | ||
layout?: 'expanded' | 'squeezed' | ||
} | ||
|
||
const Testimonial: React.FC<TestimonialProps> = ({ | ||
className, | ||
title, | ||
description, | ||
src, | ||
layout = 'squeezed', | ||
}) => { | ||
const isMobile = useIsMobile() | ||
const finalLayout = isMobile ? 'squeezed' : layout | ||
className = `testimonial ${finalLayout} ${className || ''}` | ||
|
||
return finalLayout === 'squeezed' ? ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can't this be done with css + a media query? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that was what I thought at first, but the layouts are just different. Like the puzzle doesn't fit. I can't articulate why, just look at the different versions and you can see what I mean. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's unfortunate, but happens. @melissasamworth it's all your fault!! |
||
<div className={className}> | ||
<div className="padding-bottom-24 testimonial-header"> | ||
<img width={80} height={80} className="rounded" src={src} alt="Testimonial's Face" /> | ||
<p className="default-bold padding-left-24">{title}</p> | ||
</div> | ||
<p className="default grey">{description}</p> | ||
</div> | ||
) : ( | ||
<div className={className}> | ||
<div className="flex-container"> | ||
<img width={151} height={151} className="rounded" src={src} alt="Testimonial's Face" /> | ||
<div className="padding-left-40"> | ||
<p className="large-bold padding-bottom-16">{title}</p> | ||
<p className="default grey">{description}</p> | ||
</div> | ||
</div> | ||
</div> | ||
) | ||
} | ||
|
||
export default Testimonial |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
.testimonial { | ||
border: 1px solid var(--colors-cool-grey-200); | ||
border-radius: var(--border-radius); | ||
} | ||
|
||
.testimonial.expanded { | ||
padding: var(--spacing-40); | ||
max-width: 875px; | ||
margin-left: auto; | ||
margin-right: auto; | ||
} | ||
|
||
.testimonial.squeezed { | ||
padding: var(--spacing-32); | ||
} | ||
|
||
.testimonial-header { | ||
display: flex; | ||
align-items: center; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryceerobertson I switched it here so that by default links to other pages open in a new tab. @mruwnik is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not according to me. That's what the control button is for... But there was a whole discussion about this and I think the external links faction won :/ @melissasamworth is that correct?