Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue created by new mingw compiler. #188

Open
wants to merge 1 commit into
base: campbellsean-windows-4
Choose a base branch
from
Open

Fixing issue created by new mingw compiler. #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libcollectdclient/network_parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ static int network_parse(void *data, size_t data_size, lcc_security_level_t sl,

if ((sz < 5) || (((size_t)sz - 4) > b->len)) {
DEBUG("lcc_network_parse(): invalid 'sz' field: sz = %" PRIu16
", b->len = %" PRIsz "\n",
", b->len = %" PRIu64 "\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only file affected by this issue? Seems like it would apply to any use of the PRIsz format with size_t… Why not change the definition of PRIsz in globals.h? Also, this should be fixed more comprehensively by 973ffb1 (on the igorpeshansky-windows-4 branch).

sz, b->len);
return EINVAL;
}
Expand Down