Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue created by new mingw compiler. #188

Open
wants to merge 1 commit into
base: campbellsean-windows-4
Choose a base branch
from

Conversation

rlmuolo
Copy link

@rlmuolo rlmuolo commented Sep 25, 2020

Fixes:
src/libcollectdclient/network_parse.c: In function 'network_parse':

src/libcollectdclient/network_parse.c:537:13: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'size_t' {aka 'long long unsigned int'} [-Werror=format=]

537 | DEBUG("lcc_network_parse(): invalid 'sz' field: sz = %" PRIu16

  |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

538 | ", b->len = %" PRIsz "\n",

539 | sz, b->len);

  |                 ~~~~~~

  |                  |

  |                  size_t {aka long long unsigned int}

src/libcollectdclient/network_parse.c:72:27: note: in definition of macro 'DEBUG'

72 | #define DEBUG(...) printf(VA_ARGS)

  |                           ^~~~~~~~~~~

In file included from src/libcollectdclient/network_parse.c:34:

./src/daemon/globals.h:35:17: note: format string is defined here

35 | #define PRIsz "Iu"

cc1: all warnings being treated as errors

make[1]: *** [Makefile:6545: src/libcollectdclient/libcollectdclient_la-network_parse.lo] Error 1

make[1]: Leaving directory '/tmpfs/src/collectd_src'

make: *** [Makefile:4578: all] Error 2

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rlmuolo rlmuolo force-pushed the campbellsean-windows-4 branch from 3bd7596 to b3e4e44 Compare September 25, 2020 14:48
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@@ -535,7 +535,7 @@ static int network_parse(void *data, size_t data_size, lcc_security_level_t sl,

if ((sz < 5) || (((size_t)sz - 4) > b->len)) {
DEBUG("lcc_network_parse(): invalid 'sz' field: sz = %" PRIu16
", b->len = %" PRIsz "\n",
", b->len = %" PRIu64 "\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only file affected by this issue? Seems like it would apply to any use of the PRIsz format with size_t… Why not change the definition of PRIsz in globals.h? Also, this should be fixed more comprehensively by 973ffb1 (on the igorpeshansky-windows-4 branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants