Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pycirclize version 1.7.2 #1140

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

erinyoung
Copy link
Contributor

There's a new version of pycirclize!

According to the release notes, the changes are more in documentation and windows usage, so I think this is low priority.

I copied the files from 1.7.1 and updated the version and adjusted some formatting.

$ diff pycirclize/1.7*/Dockerfile
1c1
< FROM python:3.9.17-slim as app
---
> FROM python:3.9.17-slim AS app
3c3
< ARG PYCIRCLIZE_VER="1.7.1"
---
> ARG PYCIRCLIZE_VER="1.7.2"
25c25
< CMD pip show pycirclize
---
> CMD ["pip", "show", "pycirclize"]
29c29
< FROM app as test
---
> FROM app AS test

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Sorry, something went wrong.

@kapsakcj
Copy link
Collaborator

Looks like the tests passed, although there's tons of warnings/messages that look like this from the pip install command: Skipping link: none of the wheel's tags (cp38-cp38-win32) are compatible (run pip debug --verbose to show compatible tags): https://files.pythonhosted.org/packages/6e/62/4953cafa92c330f865676db91a142898ab8c3a52ef111ffdf4b35314be98/numpy-1.22.0-cp38-cp38-win32.whl (from https://pypi.org/simple/numpy/) (requires-python:>=3.8)

Not sure if that matters or anything, maybe it's just from the pip install -vv flag?

@@ -262,7 +262,7 @@ To learn more about the docker pull rate limits and the open source software pro
| [Porechop](https://hub.docker.com/r/staphb/porechop/) <br/> [![docker pulls](https://badgen.net/docker/pulls/staphb/porechop)](https://hub.docker.com/r/staphb/porechop) | <ul><li>0.2.4</li></ul> | https://github.com/rrwick/Porechop |
| [PPanGGOLiN](https://hub.docker.com/r/staphb/ppanggolin/) <br/> [![docker pulls](https://badgen.net/docker/pulls/staphb/ppanggolin)](https://hub.docker.com/r/staphb/ppanggolin) | <ul><li>[1.2.105](./ppanggolin/1.2.105/)</li><li>[2.0.3](./ppanggolin/2.0.3/)</li><li>[2.0.5](./ppanggolin/2.0.5/)</li><li>[2.1.2](./ppanggolin/2.1.2/)</li></ul> | https://github.com/labgem/PPanGGOLiN |
| [Prokka](https://hub.docker.com/r/staphb/prokka/) <br/> [![docker pulls](https://badgen.net/docker/pulls/staphb/prokka)](https://hub.docker.com/r/staphb/prokka) | <ul><li>1.13.4</li><li>1.14.0</li><li>1.14.5</li><li>1.14.6</li></ul> | https://github.com/tseemann/prokka |
| [pyCirclize](https://hub.docker.com/r/staphb/pycirclize/) <br/> [![docker pulls](https://badgen.net/docker/pulls/staphb/pycirclize)](https://hub.docker.com/r/staphb/pycirclize) | <ul><li>[1.0.0](pycirclize/1.0.0/)</li><li>[1.2.0](./pycirclize/1.2.0/)</li><li>[1.5.0](./pycirclize/1.5.0/)</li><li>[1.6.0](./pycirclize/1.6.0/)</li><li>[1.71](./pycirclize/1.7.1/)</li></ul> | https://github.com/moshi4/pyCirclize |
| [pyCirclize](https://hub.docker.com/r/staphb/pycirclize/) <br/> [![docker pulls](https://badgen.net/docker/pulls/staphb/pycirclize)](https://hub.docker.com/r/staphb/pycirclize) | <ul><li>[1.0.0](./build-files/pycirclize/1.0.0/)</li><li>[1.2.0](./build-files/pycirclize/1.2.0/)</li><li>[1.5.0](./build-files/pycirclize/1.5.0/)</li><li>[1.6.0](./build-files/pycirclize/1.6.0/)</li><li>[1.7.1](./build-files/pycirclize/1.7.1/)</li><li>[1.7.2](./build-files/pycirclize/1.7.2/)</li></ul> | https://github.com/moshi4/pyCirclize |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating these, I have a feeling we will need to update a lot of them, if it hasn't already been done since the build-files/ dir reorganization happened

@kapsakcj kapsakcj merged commit a51f4e0 into StaPH-B:master Jan 17, 2025
2 checks passed
@kapsakcj
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants