BUGFIX - Fix deletion following refacto #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code modifications focus on two key changes: refactoring the logging in the PlaybooksRepositoryComponent and amending the filesystem operation in PlaybooksRepositoryUseCases. The logger method now wraps the logging statement in a more efficient method call, and a directory creation operation has been replaced with a file deletion operation.
The commit adds info, warn, and error functionality to the logger in the 'PlaybookRepositoryComponent' integration test. Previously, the logger only had a child method. The update makes testing more robust by providing additional logging options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code modifications focus on two key changes: refactoring the logging in the PlaybooksRepositoryComponent and amending the filesystem operation in PlaybooksRepositoryUseCases. The logger method now wraps the logging statement in a more efficient method call, and a directory creation operation has been replaced with a file deletion operation.