Merge pull request #76 from SquirrelCorporation/fix-deletion-of-file

BUGFIX - Fix deletion following refacto
SquirrelCorporation · Jul 3, 2024 · 9fb0092 · 9fb0092
2 parents 68c9bfb + ef87703
commit 9fb0092
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/server/src/integrations/playbooks-repository/PlaybooksRepositoryComponent.ts b/server/src/integrations/playbooks-repository/PlaybooksRepositoryComponent.ts
@@ -148,7 +148,9 @@ abstract class PlaybooksRepositoryComponent {
   }
 
   public fileBelongToRepository(path: string) {
-    logger.info(`rootPath: ${this.directory?.split('/')[0]} versus ${path.split('/')[0]}`);
+    this.childLogger.info(
+      `rootPath: ${this.directory?.split('/')[0]} versus ${path.split('/')[0]}`,
+    );
     return this.directory?.split('/')[0] === path.split('/')[0];
   }
 

diff --git a/server/src/tests/integrations/playbooks-repository/PlaybookRepositoryComponent.test.ts b/server/src/tests/integrations/playbooks-repository/PlaybookRepositoryComponent.test.ts
@@ -6,7 +6,11 @@ describe('PlaybooksRepositoryComponent', () => {
   let playbooksRepositoryComponent: PlaybooksRepositoryComponent;
 
   beforeEach(() => {
-    const logger = { child: vi.fn() };
+    const logger = {
+      child: () => {
+        return { info: vi.fn(), warn: vi.fn(), error: vi.fn() };
+      },
+    };
     playbooksRepositoryComponent = new LocalRepositoryComponent('uuid', logger, 'name', 'path');
   });
 

diff --git a/server/src/use-cases/PlaybooksRepositoryUseCases.ts b/server/src/use-cases/PlaybooksRepositoryUseCases.ts
@@ -109,7 +109,7 @@ async function deleteAnyInPlaybooksRepository(
   if (!playbooksRepositoryComponent.fileBelongToRepository(fullPath)) {
     throw new ForbiddenError('The selected path doesnt seems to belong to the repository');
   }
-  Shell.FileSystemManager.createDirectory(fullPath, playbooksRepositoryComponent.rootPath);
+  Shell.FileSystemManager.deleteFiles(fullPath, playbooksRepositoryComponent.rootPath);
   await playbooksRepositoryComponent.syncToDatabase();
 }