Location: Make lat/lon optional, but add more validation logic #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
force-pushed
the
112-lat-lon-optional
branch
3 times, most recently
from
f3ade43
to
e1e318d
Compare
gidsi
approved these changes
Nov 10, 2024
dbrgn
force-pushed
the
112-lat-lon-optional
branch
2 times, most recently
from
cf12fed
to
1d32216
Compare
- The `location` fields needs at least one property - If `lat` is specified, then `lon` is required as well (and vice versa)
dbrgn
force-pushed
the
112-lat-lon-optional
branch
from
1d32216
to
18c8650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
latandlonfields optional (see discussion in #112), but adds some validation logic:locationfields needs at least one propertylatis specified, thenlonis required as well (and vice versa)This means that
"location": {},is not valid (at least 1 property required), neither is"location": {"lat": 1.23}(both lat and lon) must be specified). But"location": {"timezone": "Antarctica/Palmer"}is valid.Logic is based on the latest JSON Schema validation draft. I don't know whether there is significant support in tooling for these fields.
Fixes #112