Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs generator improvements #138

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Docs generator improvements #138

merged 4 commits into from
Nov 12, 2024

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Nov 10, 2024

  • Add support for minProperties
  • Add support for dependentRequired
  • Introduce attributes system that uses definition lists in the generated HTML

This will be a requirement for schema 15 docs if SpaceApi/schema#115 is merged.

Refs #137.

@dbrgn dbrgn requested a review from a team November 10, 2024 19:06
@dbrgn dbrgn self-assigned this Nov 10, 2024
s3lph
s3lph approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good idea to use dl's for that.

@s3lph s3lph merged commit 620a8b1 into master Nov 12, 2024
1 check passed
@s3lph s3lph deleted the docs-generator-improvements branch November 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3lph s3lph s3lph approved these changes

Assignees

@dbrgn dbrgn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrgn @s3lph