Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created apis for handling login and signup #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abhayksahu369
Copy link

#48 done

created apis for handling login and signup request from frontend

  • the api will let user register and login
  • the api will store user's username,email and password in the mongodb database
  • please create a .env file and add MONGODB_URL=you_mongodb_database_url
  • create a mongodb Atlas database for this app and copy the link and put it in .env file

Copy link

vercel bot commented Oct 8, 2024

@abhayksahu369 is attempting to deploy a commit to the Soumojit Shome Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@BaibhavTiwari BaibhavTiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested Improvements:

  • Use bcrypt to hash and compare passwords securely.

Storing plain text passwords is a major security risk. You should hash the password before storing it in the database.

  • Standardize error handling to provide more meaningful responses.

  • Omit sensitive data (like passwords) from the response.

Password and other sensitive data should not be included in any response.

  • Use JWT for authentication to handle login tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants