Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-981,SLE-980: Update labels and icons for rebranding #764

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

thahnen
Copy link
Member

@thahnen thahnen commented Nov 12, 2024

SLE-981

Update all the user-facing labels, including notifications, dialogs, views, popups, and further visible information. Additionally, add the new icons.

Update all the user facing labels, including notifications, dialogs, views, popups and further visible information.
@thahnen thahnen force-pushed the feat/tha/MMF-4066_Rebranding branch 2 times, most recently from 8645245 to 7e44993 Compare November 13, 2024 15:22
@thahnen thahnen changed the title SLE-981: Update labels for rebranding SLE-981,SLE-980: Update labels and icons for rebranding Nov 15, 2024
@thahnen thahnen marked this pull request as ready for review November 15, 2024 14:51
@nquinquenel nquinquenel self-requested a review November 15, 2024 14:55
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that on specific locations you have to use SonarQube instead of SonarQube for Eclipse, but I believe that sometimes you could use the full name when you are not restricted by the size of the panel (in settings, notifications, etc.). WDYT?

@thahnen
Copy link
Member Author

thahnen commented Nov 15, 2024

@nquinquenel Most of the time when I use SonarLint for Eclipse is is about something that is specific to the IDE plug-in. Otherwise I will use SonarQube, and also for views or UI parts where a larger text won't fit.

Update all the user facing icons. Remove the old GIMP files as they are not used anymore.
Based on PR review and validation feedback.
Due to the Gradle integration the tests sometime intertwine and are therefore flaky.
Due to issues with the rebranding and Orchestrator we have to set a static version for now. Will be fixed later.
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thahnen thahnen merged commit e87b4cd into master Nov 18, 2024
16 checks passed
@thahnen thahnen deleted the feat/tha/MMF-4066_Rebranding branch November 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants