Son 2159 support C pins #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
430: fix vscode rust-analazer r=richardeoin a=burrbull Co-authored-by: Andrey Zgarbul <[email protected]>
replace bors with merge queue
Added VOS0 support for stm32h7a3/7b3/7b0
update GPIO 2
Reorder [[example]] targets alphabetically Remove some unnessesary required features Tidy documentation in sai_dma_passthru example
Changes to be committed: modified: Cargo.toml new file: examples/blinky-stm32h747i-disco.rs by Youndong ([email protected])
check code formatting
…Update DSI examples.
…ify examples run commands. Reformat.
Add new blinky example using GPIOs on STM32H747i-Disco
MIPI DSI Display HAL
rust/#114447 made `&mut MY_STATIC_MUT` a warning, with the intention of disallowing it entirely in the 2024 edition. We never used this in the crate itself, but it is used in many examples. This commit removes these references from the examples. In general the new approach is to change `static mut` of type `X` to type `MaybeUninit<X>`. These can then cleanly be accessed with [`MY_STATIC_MUT.write()`](https://doc.rust-lang.org/core/mem/union.MaybeUninit.html#method.write) followed by [`MY_STATIC_MUT.assume_init_mut()`](https://doc.rust-lang.org/core/mem/union.MaybeUninit.html#method.assume_init_mut). Where we need to cast a `MaybeUninit<[X; N]>` to a `[MaybeUninit<X>; N]` in order to initialise it element-by-element, the `&mut *ptr::addr_of_mut!(MY_STATIC_MUT)` construction is still used. After initialisation, we can then access it with `MY_STATIC_MUT.assume_init_mut()`. In a few DMA Examples we were taking a reference `&mut TARGET_BUFFER` without initialising TARGET_BUFFER. This commit changes this to `TARGET_BUFFER.assume_init_mut()` *without* initialising `TARGET_BUFFER`. This was and remains UB. * USB Examples: `static mut EP_MEMORY` now has type `MaybeUninit<[u32; 1024]>` * Ethernet Examples: `static mut DES_RING` now has type `MaybeUninit<ethernet::DesRing<4, 4>>`
Also remove extra "proto-ipv6" feature that is not needed by examples
`TryFrom` and `TryInto` part of the prelude [since the 2021 edition](https://doc.rust-lang.org/edition-guide/rust-2021/prelude.html). stm32-rs#236
espenalb
approved these changes
May 15, 2024
src/adc.rs
Outdated
| @@ -64,6 +64,10 @@ | |||
| use core::marker::PhantomData; | |||
|
|
|||
| use crate::rcc::ResetEnable; | |||
| // EB: Todo: If making PR upstream, this should only be include for some boards (see pwr.rs) | |||
| use crate::stm32::SYSCFG; | |||
| // EB: Todo: If making PR upstream, check which boards has relevant Pxy_C pins and update | |||
There was a problem hiding this comment.
No, this involves going through the data sheets for all the supported MCUs (there are at least 13) and the package information for each of those (probably 3-5 for each MCU) to see which have these pins (and then add feature flags in the right places), so it is a rather big undertaking...
endresonair
force-pushed
the
SON-2159-Support-C-pins2
branch
from
65edd72 to
6f13b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.