Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup workflows and makefile #2150

Merged
merged 30 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e5daf49
cleanup workflows and makefile
sfc-gh-swinkler Oct 25, 2023
aa01700
update makefile
sfc-gh-swinkler Oct 25, 2023
4b0df5e
update makefile
sfc-gh-swinkler Oct 25, 2023
1c71e9f
update makefile
sfc-gh-swinkler Oct 25, 2023
f3f553b
update makefile
sfc-gh-swinkler Oct 25, 2023
b8b27b3
update makefile
sfc-gh-swinkler Oct 25, 2023
ed0e002
update makefile
sfc-gh-swinkler Oct 25, 2023
0c01730
update makefile
sfc-gh-swinkler Oct 25, 2023
95eb2c7
update makefile
sfc-gh-swinkler Oct 25, 2023
f2a9518
update makefile
sfc-gh-swinkler Oct 25, 2023
5167f02
update makefile
sfc-gh-swinkler Oct 25, 2023
949af08
add skip tests
sfc-gh-swinkler Oct 25, 2023
1344d7d
rename files and remove copywrite
sfc-gh-swinkler Oct 25, 2023
e1a8296
remove license
sfc-gh-swinkler Oct 25, 2023
f6626d0
remove license
sfc-gh-swinkler Oct 25, 2023
c1714c8
remove license
sfc-gh-swinkler Oct 25, 2023
bbef44a
fix comments
sfc-gh-swinkler Oct 25, 2023
dd45d45
change to yml
sfc-gh-swinkler Oct 25, 2023
64169f0
fmt
sfc-gh-swinkler Oct 25, 2023
641daba
revert goreleaser
sfc-gh-swinkler Oct 25, 2023
55efde7
revert reviewdog file
sfc-gh-swinkler Oct 25, 2023
51f8f45
update makefile
sfc-gh-swinkler Oct 25, 2023
1ef7435
remove check-fmt
sfc-gh-swinkler Oct 25, 2023
14c63b2
fix comments
sfc-gh-swinkler Nov 17, 2023
9b29edb
Merge branch 'main' into makefile-cleanup
sfc-gh-swinkler Nov 17, 2023
9e50e9f
mod fix
sfc-gh-swinkler Nov 17, 2023
7549f0a
update docs
sfc-gh-swinkler Nov 17, 2023
736f5c4
update docs
sfc-gh-swinkler Nov 17, 2023
6e70b4d
update makefile
sfc-gh-swinkler Nov 21, 2023
0d4d611
Merge branch 'main' into makefile-cleanup
sfc-gh-swinkler Nov 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
20 changes: 20 additions & 0 deletions .copywrite.hcl
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
schema_version = 1
sfc-gh-asawicki marked this conversation as resolved.
Show resolved Hide resolved

project {
license = "MIT"
copyright_holder = "Snowflake, Inc."
copyright_year = 2022
header_ignore = [
# examples used within documentation (prose)
"examples/**",

# GitHub issue template configuration
".github/ISSUE_TEMPLATE/*.yml",

# golangci-lint tooling configuration
".golangci.yml",

# GoReleaser tooling configuration
".goreleaser.yml",
]
}
107 changes: 76 additions & 31 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,77 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''
name: Bug Report
description: Something is incorrect or not working as expected.
labels: ["bug"]
body:
- type: markdown
attributes:
value: |
Thank you for taking the time to fill out this bug report! Please note that this issue tracker is only used for bug reports and feature requests. Other issues will be closed.

---

**Provider Version**

The provider version you are using.

**Terraform Version**

The version of Terraform you were using when the bug was encountered.

**Describe the bug**

A clear and concise description of what the bug is.

**Expected behavior**

A clear and concise description of what you expected to happen.

**Code samples and commands**

Please add code examples and commands that were run to cause the problem.

**Additional context**

Add any other context about the problem here.
If you have a configuration, workflow, or other question, please go back to the issue chooser and select one of the question links.
- type: textarea
id: versions
attributes:
label: Terraform CLI and Provider Versions
description: What versions of Terraform CLI and the provider?
placeholder: Output of `terraform version` from configuration directory
validations:
required: true
- type: textarea
id: terraform-configuration
attributes:
label: Terraform Configuration
description: Please copy and paste any relevant Terraform configuration. This will be automatically formatted into code, so no need for backticks.
render: terraform
validations:
required: true
- type: textarea
id: expected-behavior
attributes:
label: Expected Behavior
description: What did you expect to happen?
placeholder: Description of what should have happened.
validations:
required: true
- type: textarea
id: actual-behavior
attributes:
label: Actual Behavior
description: What actually happened?
placeholder: Description of what actually happened.
validations:
required: true
- type: textarea
id: reproduction-steps
attributes:
label: Steps to Reproduce
description: List of steps to reproduce the issue.
value: |
1. `terraform apply`
validations:
required: true
- type: dropdown
id: impact
attributes:
label: How much impact is this issue causing?
description: High represents completely not able to use the provider or unexpected destruction of data/infrastructure. Medium represents unable to upgrade provider version or an issue with potential workaround. Low represents minor provider code, configuration, or documentation issues.
options:
- High
- Medium
- Low
validations:
required: true
- type: input
id: logs
attributes:
label: Logs
description: Please provide a link to a [GitHub Gist](https://gist.github.com) containing TRACE log output. [Terraform Debugging Documentation](https://www.terraform.io/internals/debugging)
placeholder: https://gist.github.com/example/12345678
validations:
required: false
- type: textarea
id: additional-information
attributes:
label: Additional Information
description: Are there any additional details about your environment, workflow, or recent changes that might be relevant? Have you discovered a workaround? Are there links to other related issues?
validations:
required: false
52 changes: 52 additions & 0 deletions .github/ISSUE_TEMPLATE/documentation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: "Report a Documentation Error"
description: "Choose this option if you've found an error in the provider documentation or contribution guides."
title: "[Docs]: "
labels: ["documentation"]
body:
- type: markdown
attributes:
value: |
# Thank you for raising a documentation issue!

This form is meant to alert the maintainers to an issue with the provider documentation found on the [Terraform Registry](https://registry.terraform.io/providers/hashicorp/snowflake/latest) (such as resource and data source documentation, guides and examples), as well as the [contribution guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/CONTRIBUTING.md).

Documentation edits are generally a bit less involved, so are often a great entrypoint if you've ever been interested in contributing!

- type: input
id: registry_link
attributes:
label: Documentation Link
description: Please provide a link to the affected page on the Terraform Registry or contribution guide.
validations:
required: true

- type: textarea
id: description
attributes:
label: Description
description: Please leave a brief description of the documentation issue.
validations:
required: true

- type: textarea
id: references
attributes:
label: References
description: |
Where possible, please supply links to Snowflake SQL documentation, other GitHub issues (open or closed) or pull requests that give additional context.

[Information about referencing Github Issues](https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
validations:
required: false

- type: dropdown
id: will_contribute
attributes:
label: Would you like to implement a fix?
description: |
If you plan to implement a fix for this, check this box to let the maintainers and community know (you can update this later if you change your mind). If this would be your first contribution, refer to the [contribution guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/CONTRIBUTING.md) for tips on getting started.
options:
- "No"
- "Yes"
validations:
required: false
76 changes: 52 additions & 24 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,52 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: feature-request
assignees: ''

---

**Is your feature request related to a problem? Please describe.**

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**

A clear and concise description of what you want to happen.

**Describe alternatives you've considered**

A clear and concise description of any alternative solutions or features you've considered.

**Additional context**

Add any other context or screenshots about the feature request here.
name: Feature Request
description: Something is missing or could be improved.
labels: ["feature-request"]
body:
- type: markdown
attributes:
value: |
Thank you for taking the time to fill out this feature request! Please note that this issue tracker is only used for bug reports and feature requests. Other issues will be closed.

If you have a configuration, workflow, or other question, please go back to the issue chooser and select one of the question links.
- type: textarea
id: versions
attributes:
label: Terraform CLI and Provider Versions
description: What versions of Terraform CLI and the provider?
placeholder: Output of `terraform version` from configuration directory
validations:
required: true
- type: textarea
id: use-case
attributes:
label: Use Cases or Problem Statement
description: What use cases or problems are you trying to solve?
placeholder: Description of use cases or problems.
validations:
required: true
- type: textarea
id: proposal
attributes:
label: Proposal
description: What solutions would you prefer?
placeholder: Description of proposed solutions.
validations:
required: true
- type: dropdown
id: impact
attributes:
label: How much impact is this issue causing?
description: High represents completely not able to use the provider without this. Medium represents unable to solve a specific problem or understand something. Low represents minor provider code, configuration, or documentation issues.
options:
- High
- Medium
- Low
validations:
required: true
- type: textarea
id: additional-information
attributes:
label: Additional Information
description: Are there any additional details about your environment, workflow, or recent changes that might be relevant? Have you discovered a workaround? Are there links to other related issues?
validations:
required: false
5 changes: 5 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,14 @@ version: 2
updates:
- package-ecosystem: gomod
directory: '/'
open-pull-requests-limit: 10
schedule:
interval: daily
- package-ecosystem: "gomod"
directory: "/tools"
open-pull-requests-limit: 10
schedule:
interval: "daily"
- package-ecosystem: 'github-actions'
directory: '/'
schedule:
Expand Down
30 changes: 30 additions & 0 deletions .github/workflows/acc-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Run secret-dependent integration tests only after /ok-to-test approval
on:
pull_request:
branches: [ main ]
paths-ignore:
- 'README.md'
- 'CHANGELOG.md'
name: acceptance

jobs:
test:
name: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version-file: ./go.mod
cache: false
- name: Install dependencies
run: make tools
- name: Create and populate .snowflake/config file
run: mkdir $HOME/.snowflake && echo "${{ secrets.SNOWFLAKE_CONFIG_FILE }}" > $HOME/.snowflake/config
- run: make testacc
env:
SKIP_EMAIL_INTEGRATION_TESTS=true
sfc-gh-asawicki marked this conversation as resolved.
Show resolved Hide resolved
SKIP_EXTERNAL_TABLE_TEST=true
SKIP_NOTIFICATION_INTEGRATION_TESTS=true
SKIP_SAML_INTEGRATION_TESTS=true
SKIP_STREAM_TEST=true
51 changes: 0 additions & 51 deletions .github/workflows/codeql-analysis.yml

This file was deleted.

Loading