-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup workflows and makefile #2150
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really hard change to be reviewed because it introduces many things we did not discuss before. It should be split into several different PRs and discussed before, so that we are all aware WHAT and WHY is being changed/introduced. Furthermore moving the package to internal was really not needed, it just messes now with all other open PRs/branches and introduces history change which makes the history of a file harder to follow.
internal/resources/testdata/TestAcc_DynamicTable_basic/3/test.tf
Outdated
Show resolved
Hide resolved
* Run only acceptance tests in test acceptance * Revert sweepers, comments, and unified tests setup * Fix workflow config * Skip tests due to introduced breaking change in #2150 * Fix workflow config
integration.yml
workflow into separatetest-acceptance.yml
andtest-unit-and-integration.yml
workflows. This should speed up by about 6 minutesmake fmt
to format all the terraform files and rungo fumpt