Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup workflows and makefile #2150

Merged
merged 30 commits into from
Nov 22, 2023
Merged

fix: cleanup workflows and makefile #2150

merged 30 commits into from
Nov 22, 2023

Conversation

sfc-gh-swinkler
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler commented Oct 25, 2023

  • changing some of the workflows and makefile to better follow convention.
  • split integration.yml workflow into separate test-acceptance.yml and test-unit-and-integration.yml workflows. This should speed up by about 6 minutes
  • removed the slack workflow which wasn't being used
  • remove the codecov.yml file which wasn't being used
  • ran make fmt to format all the terraform files and run go fumpt
  • updated release.yml to use emojis

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really hard change to be reviewed because it introduces many things we did not discuss before. It should be split into several different PRs and discussed before, so that we are all aware WHAT and WHY is being changed/introduced. Furthermore moving the package to internal was really not needed, it just messes now with all other open PRs/branches and introduces history change which makes the history of a file harder to follow.

.copywrite.hcl Outdated Show resolved Hide resolved
GNUmakefile Outdated Show resolved Hide resolved
.github/workflows/acc-test.yml Outdated Show resolved Hide resolved
GNUmakefile Outdated Show resolved Hide resolved
GNUmakefile Outdated Show resolved Hide resolved
GNUmakefile Outdated Show resolved Hide resolved
tools/tools.go Outdated Show resolved Hide resolved
tools/tools.go Show resolved Hide resolved
internal/sdk/external_tables_dto_builders_gen.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
GNUmakefile Outdated Show resolved Hide resolved
GNUmakefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
GNUmakefile Outdated Show resolved Hide resolved
.github/workflows/team-slack-bot.yml Show resolved Hide resolved
.github/workflows/unit.yml Show resolved Hide resolved
tools/tools.go Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 20, 2023 09:38
Makefile Outdated Show resolved Hide resolved
@sfc-gh-swinkler sfc-gh-swinkler merged commit 64335e7 into main Nov 22, 2023
5 of 8 checks passed
@sfc-gh-swinkler sfc-gh-swinkler deleted the makefile-cleanup branch November 22, 2023 07:25
sfc-gh-asawicki added a commit that referenced this pull request Nov 22, 2023
* Run only acceptance tests in test acceptance

* Revert sweepers, comments, and unified tests setup

* Fix workflow config

* Skip tests due to introduced breaking change in #2150

* Fix workflow config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants