Make Definition extensible #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of #808
Implementation
DefinitioninheritExtensibleListenersupercall of the constructor after other ivars are initialisedExtension#create_definition_listenerAutomated Tests
I added 1 test for the extension. But given
Definition#merge_response!needs to handle a few more cases for combination of response types (nil | Location | Array of Location), we could use more tests cover them.However, all the cases should already be checked by Sorbet and it'd be very lengthy to make tests populate different definition results while calling extensions. So I'm not sure if it'd be worth the effort.
Manual Tests