-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more requests to be extended #808
Comments
Today at the DX stream meeting we talked about that on some requests, we may need to expose more info or even make certain data mutable to our extensions. I think semantic highlight may be one of them. Consider this: class Foo < ApplicationRecord
before_save :bar
end Currently @vinistock can you check if my understanding on this case is correct. And if it is, should we still make it extensible before we discuss further about the data flow between ruby-lsp/extensions? |
Yes, your understanding is correct. We'll indeed need to think of a better strategy if two extensions want to modify the same semantic token. Let's put this on pause while we plan of a better abstraction for merging responses from extensions. |
I think this has been completed as the response building mechanism has been completely redesigned and individual requests can decide how their responses should be exposed to addons pretty easily. |
In #782, we encapsulated the logic to execute multiple listeners in the base implementations. Let's generalize this even more to be implemented in the parent
Listener
class and let's expose a configuration to allow requests to be extended.Something like this
Then let's allow the following requests to be enhanced by extensions:
The text was updated successfully, but these errors were encountered: