Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): replace "action" to "loader" in the login function comment #2712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(docs): replace "action" to "loader" in the login function comment #2712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
331ccae
chore(docs): specify both loader and action option for in the login f…
liady Jan 16, 2025
ba76aec
remove action and fix to be loader-only
liady Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/hydrogen/src/customer/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export type LogoutOptions = {
};

export type CustomerAccount = {
/** Start the OAuth login flow. This function should be called and returned from a Remix action.
/** Start the OAuth login flow. This function should be called and returned from a Remix loader.
* It redirects the customer to a Shopify login domain. It also defined the final path the customer
* lands on at the end of the oAuth flow with the value of the `return_to` query param. (This is
* automatically setup unless `customAuthStatusHandler` option is in use)
Expand Down
Loading