Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): replace "action" to "loader" in the login function comment #2712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

liady
Copy link

@liady liady commented Jan 16, 2025

WHY are these changes introduced?

Currently the comment for our CustomerAccount#login function specify it should be called and returned from an action, though it should be done from a loader - and this is what we also write in our docs.

WHAT is this pull request doing?

Fixes the wording in the comment.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

shopify bot commented Jan 16, 2025

Oxygen deployed a preview of your chore/login-comment-fix branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment January 16, 2025 5:10 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment January 16, 2025 5:10 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment January 16, 2025 5:10 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment January 16, 2025 5:10 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment January 16, 2025 5:10 PM

Learn more about Hydrogen's GitHub integration.

@liady liady changed the title chore(docs): specify both loader and action option for in the login function comment chore(docs): specify both loader and action options in the login function comment Jan 16, 2025
@liady liady requested a review from wizardlyhel January 16, 2025 16:34
@liady liady changed the title chore(docs): specify both loader and action options in the login function comment chore(docs): replace "action" to "loader" in the login function comment Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants