-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix out-of-place version of FineRKN5 #1973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something was off with the "out-of-place" version of FineRKN5
. I missed these mistakes, thank you for fixing them!
I will add convergence test for the damped_oscillator
in another PR.
I don't think the failing downstream tests are related to this PR - but they fail badly, e.g.,
|
@ChrisRackauckas This should be good, I think. @HenryLangner can update his recent PRs #1975 and #1976 with additional tests once this PR is merged. |
Was there a necessary order here? I merged the one I saw that looked good to go, so I think this just needs a quick merge resolution to be merged next? #1975 then has a few conflicts so it can be merged shortly after. |
It was messed up a bit since @HenryLangner pulled the changes I made here into his PR. But it's fine, I fixed the merge conflicts here. I propose to merge this first and let @HenryLangner resolve the merge conflicts in #1975 afterwards, updating also the new tests added here with the new algorithm. |
Sounds good. Once this PR is merged I will update my PR #1975, resolve merge conflicts and update the new tests. |
I found some typos in out-of-place version of
FineRKN5()
and fixed them. I also added some tests checking that the in-place and out-of-place versions of some Runge-Kutta-Nyström methods. Some of these are currently broken, in particular with adaptive time stepping. I propose to open an issue and check them later.I also fixed the reported number of function evaluations of some methods and added some checks for them.
CC @HenryLangner