New algorithm FineRKN4()
#1977
Merged
New algorithm FineRKN4()
#1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranocha
approved these changes
Jun 22, 2023
Comment on lines
+401
to
+409
| sim = test_convergence(dts, prob, Nystrom4(), dense_errors = true) | ||
| @test sim.𝒪est[:l2]≈4 rtol=1e-1 | ||
| @test sim.𝒪est[:L2]≈4 rtol=1e-1 | ||
| sim = test_convergence(dts, prob, FineRKN4(), dense_errors = true) | ||
| @test sim.𝒪est[:l2]≈4 rtol=1e-1 | ||
| @test sim.𝒪est[:L2]≈4 rtol=1e-1 | ||
| sim = test_convergence(dts, prob, FineRKN5(), dense_errors = true) | ||
| @test sim.𝒪est[:l2]≈5 rtol=1e-1 | ||
| @test sim.𝒪est[:L2]≈4 rtol=1e-1 |
There was a problem hiding this comment.
Interesting! So the methods seem to have some superconvergence properties for the harmonic oscillator without damping but not for the version with damping used here.
(nothing blocking this PR from being merged, just an observation)
|
@ChrisRackauckas This is ready to be merged from my point of view. I don't see how the SciMLSensitivity failures could be related to this. |
|
Oh yes, I just missed this one sorry. |
|
No problem, this can easily happen given the amount of packages you maintain. Thanks |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR #1975 got a little messed up with all the changes across the three PRs (#1975, #1973 and #1976).
Just to be safe I added all the features introduced in #1975 to this up to date branch. With this PR I will close #1975.
The new algorithm
FineRKN4()is added. In addition I have added the necessary tests (convergence, regression and the comparison tests between fixed step size and adaptive step size).Furthermore there is now a convergence test for the damped oscillator. Since
FineRKN4()andFineRKN5()are generalized RK-Nyström methods, they can be directly applied on velocity depended second order ODEs. To test their convergence on these type of ODEs the damped oscillator is added.CC @ranocha