Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsat fixes (2nd attempt) #38

Merged
merged 1 commit into from
Jul 9, 2024
Merged

rsat fixes (2nd attempt) #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/codi/tapes/commonTapeImplementation.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,9 @@ namespace codi {
func.template call<callType>(&impl, dataView, std::forward<Args>(args)...);

codiAssert(endPos == dataView.getPosition());
} else if (LowLevelFunctionEntryCallKind::Delete == callType) CODI_Unlikely {
} else CODI_Unlikely if (LowLevelFunctionEntryCallKind::Delete == callType) {
// No delete registered. Data is skiped by the curLLFByteDataPos update.
} else CODI_Unlikely {
} else {
CODI_EXCEPTION("Requested call is not supported for low level function with token '%d'.", (int)id);
}

Expand Down
2 changes: 1 addition & 1 deletion include/codi/tapes/jacobianBaseTape.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ namespace codi {

CODI_NO_INLINE void internalResizeAdjointsVector() {
// overallocate as next multiple of Config::ChunkSize
adjoints.resize(getNextMultiple((size_t)indexManager.get().getLargestCreatedIndex() + 1, Config::ChunkSize));
adjoints.resize(getNextMultiple(indexManager.get().getLargestCreatedIndex() + 1, (Identifier)Config::ChunkSize));
}
};
}
2 changes: 1 addition & 1 deletion include/codi/tapes/jacobianLinearTape.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ namespace codi {
// curAdjointPos at the end of the loop.

EventSystem<JacobianLinearTape>::notifyStatementEvaluateListeners(
tape, curAdjointPos, GradientTraits::dim<Adjoint>(), GradientTraits::toArray(lhsAdjoint).data());
tape, (Identifier)curAdjointPos, GradientTraits::dim<Adjoint>(), GradientTraits::toArray(lhsAdjoint).data());

if (Config::ReversalZeroesAdjoints) {
adjointVector[curAdjointPos] = Adjoint();
Expand Down