Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Max, I recently compiled CoDiPack with an rsat checker and had to change these 3 places to make it work.
for include/codi/tapes/commonTapeImplementation.hpp I get the error:
error: both branches of 'if' statement marked as 'unlikely' [-Werror=attributes]
394 | #define CODI_Unlikely [[unlikely]]
note: in expansion of macro 'CODI_Unlikely'
538 | } else if (LowLevelFunctionEntryCallKind::Delete == callType) CODI_Unlikely {
for include/codi/tapes/jacobianBaseTape.hpp I get the error:
error: conversion from 'long unsigned int' to 'codi::LocalAdjoints<double, int, codi::JacobianLinearTape<codi::JacobianTapeTypes<double, double, codi::LinearIndexManager, codi::DefaultChunkedData, codi::LocalAdjoints> > >::Identifier' {aka 'int'} may change value [-Werror=conversion]
[build] 870 | adjoints.resize(getNextMultiple((size_t)indexManager.get().getLargestCreatedIndex() + 1, Config::ChunkSize));
for include/codi/tapes/jacobianLinearTape.hpp I get the error:
error: conversion from 'size_t' {aka 'long unsigned int'} to 'codi::EventSystem<codi::JacobianLinearTape<codi::JacobianTapeTypes<double, double, codi::LinearIndexManager, codi::DefaultChunkedData, codi::LocalAdjoints> > >::Identifier' {aka 'int'} may change value [-Werror=conversion]
203 | tape, curAdjointPos, GradientTraits::dim(), GradientTraits::toArray(lhsAdjoint).data());
These changes make it work.