Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the same act options to be added multiple times #142

Merged
merged 12 commits into from
Jan 19, 2025
Merged

Allow the same act options to be added multiple times #142

merged 12 commits into from
Jan 19, 2025

Conversation

SanjulaGanepola
Copy link
Owner

✍ Changes

  • Allow the same act options to be added multiple times

📋 Checklist

  • I tested my changes
  • I updated relevant documentation
  • I added myself to the contributors' list

ChristopherHX and others added 10 commits December 14, 2024 00:48
@ChristopherHX
extract act options from cli command
e87364b
@ChristopherHX
remove special options handled by the tree view
3de4a30
@SanjulaGanepola
Refactor logic to get act options (#1)
2f8fcba 
* Refactor get options logic
* Remove bool type options from having descriptions
* Force option description to be uppercase

Signed-off-by: Sanjula Ganepola <[email protected]>
@ChristopherHX
disable generic early exit options as well
396b2e7
@ChristopherHX
filter out stringArray default value
a931ef4 
* this removes default values like `[]` regardless if they are sent
@ChristopherHX
fix quote consitency
bcdaddb
@ChristopherHX
Merge branch 'main' into feature/extract-options-from-command
2f95e6d
@SanjulaGanepola
Fix lint errors and move default options to separate func
8df2c4b 
Signed-off-by: Sanjula Ganepola <[email protected]>
@SanjulaGanepola
Allow multiple of the same options to support stringArray type
bfeb390 
Signed-off-by: Sanjula Ganepola <[email protected]>
@SanjulaGanepola
Resolve merge conflicts
689265c 
Signed-off-by: Sanjula Ganepola <[email protected]>
@SanjulaGanepola SanjulaGanepola linked an issue Jan 18, 2025 that may be closed by this pull request
Handle stringArray type of getAllOptions and render a subtree like for --var and --secret with an add button #129
Closed
@SanjulaGanepola SanjulaGanepola mentioned this pull request Jan 18, 2025
Closed
@SanjulaGanepola
Fix comment
76e3cf3 
Signed-off-by: Sanjula Ganepola <[email protected]>
ChristopherHX
ChristopherHX reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not testing this myself before next Tuesday

I just remembered that --list-options is not excluded from add options

src/views/settings/settingsTreeDataProvider.ts Show resolved Hide resolved
@SanjulaGanepola
Exclude list options
3886965 
Signed-off-by: Sanjula Ganepola <[email protected]>
@SanjulaGanepola
Copy link
Owner Author

@ChristopherHX I am going to merge this PR so that I can open another one to fix issues with boolean options. If you find any issues with this change, please comment here or in the other PR after your testing.

@SanjulaGanepola SanjulaGanepola merged commit 375ca40 into main Jan 19, 2025
3 checks passed
@SanjulaGanepola SanjulaGanepola deleted the fix/settings-options branch January 19, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHX ChristopherHX ChristopherHX left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle stringArray type of getAllOptions and render a subtree like for --var and --secret with an add button
2 participants
@SanjulaGanepola @ChristopherHX