Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle stringArray type of getAllOptions and render a subtree like for --var and --secret with an add button #129

Closed
ChristopherHX opened this issue Dec 22, 2024 · 2 comments · Fixed by #142
Closed

Handle stringArray type of getAllOptions and render a subtree like for --var and --secret with an add button #129

ChristopherHX opened this issue Dec 22, 2024 · 2 comments · Fixed by #142
Assignees
@SanjulaGanepola
Labels
enhancement New feature or request

Comments

@ChristopherHX
Copy link
Contributor

Github Local Actions Version

dev

Act Version

0.2.70

Feature Description

Currently we can only configure at most one value of the stringArray Option.

A subtree like for vars and env with an plus + buttons could remove this constraint.

needs #117
@ChristopherHX ChristopherHX added the enhancement New feature or request label Dec 22, 2024
@ChristopherHX ChristopherHX mentioned this issue Dec 22, 2024
Merged
3 tasks
@SanjulaGanepola SanjulaGanepola linked a pull request Jan 18, 2025 that will close this issue
Allow the same act options to be added multiple times #142
Merged
3 tasks
@SanjulaGanepola
Copy link
Owner

@ChristopherHX In this PR, I opted for simply allowing multiple of the same act options to be added instead of using a subtree. If more users find that a subtree might be better, we can re-open this issue.

@ChristopherHX
Copy link
Contributor Author

simply allowing multiple of the same act options to be added instead of using a subtree

Either way you can then add multiple values, so solved in my point of view.

@SanjulaGanepola SanjulaGanepola self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SanjulaGanepola SanjulaGanepola

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow the same act options to be added multiple times SanjulaGanepola/github-local-actions
2 participants
@SanjulaGanepola @ChristopherHX