Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison between integer expressions #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix comparison between integer expressions #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/cyad/commandline_options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ TEST(CommandlineOptions, allOptionsPresent) {
using Cynara::CmdlineOpts::commandlineOptions;

// A cheap trick to make sure this test is updated, when new options are added
ASSERT_EQ(18, commandlineOptions.size());
ASSERT_EQ(18u, commandlineOptions.size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. As far as I know, you are still employee of Samsung.
    Making such a change - please update Samsung's copyrights.

  2. Please make your changes compatible with the way, there were fixed previously, e.g. in commit ed1c9d5


ASSERT_NO_THROW(commandlineOptions.at(CmdlineOpt::SetBucket));
ASSERT_NO_THROW(commandlineOptions.at(CmdlineOpt::DeleteBucket));
Expand Down